What Changed in July, August and September 2019
to Saturday 6 July 2019
- Extensive work to put icons on the canalplan tiles for the mapping subsystem
- Code to build icon svg files from a configuration file
- Code to build new sprite files from combined standard and my icons
- Rebuild of geojson-making program to put icons names into the geojson based on place attributes
- And other things such as rotation
- Redesign of style files to use this data
Final result is symbols on the maps, all done via the tileserver and mapboxgl.js, no code of my own at the front end at all.
- Added a new "as lookup" extension to the language iterators (for loops) to make writing some of the parsing code easier.
→ Release 9.33
- Added code to produce @2x sprite files, and pushed to server. When subsequently tweaked to correct a minor typo they fixed half of issue 622, where icons weren't showing on high resolution screens.
Sunday 7 July 2019
- Fixed bug from yesterday (which I'd done a quick patch on) where layer names were hard wired into the JavaScript — the second half of issue 622 where you couldn't click on icons/names. As so often, the solution is far more elegant, and it lets me write code like map.getStyle().layers.filter(layer => layer.id.startsWith('cp-waterway-')).forEach(function(v) { , which has to be good.
- Fixed another very subtle bug: if you have a junction that is also a lock or a bridge (which happens, at least, at Wardle Lock and at Leigh Bridge; these are both end-on junctions and I don't think it should happen anywhere else) then the rotation calculation didn't work and the icon ended up aligned on a pure N-S axis. Special case code to spot and calculate the rotation written.
→ Release 9.33.1
- Redescribed the 'f'-"flight" attribute as "place in a flight" rather than "lock in a flight", because that's how it is actually used. Updated the documentation as well!
- Fixed missed change in .htaccess to restart showing cached gazetteer pages to search engines, which should be a big help as we are getting a lot of timeouts at the moment (there are a ridiculous number of sites scraping us, just from those I've noticed in user agent strings in crash reports)
Monday 8 July 2019
- Rough-and-ready integration of C&RT asset codes into place geodata (released to beta)
Thursday 11 July 2019
- Changed message about visiting places in gazetteers to make it read better, delivering improvement in issue 624
Friday 12 July 2019
- Improved code flow round the "at least" decision in totals
- Fixed bug where it always used the UK message there!
- Some "struct" to "feature" changes in output macros while I was there
Saturday 13 July 2019
- Added format line so "edit_bridge_JSON has no format" didn't appear when you visited some place history records
- Fixed link to users in history tab of in-place editing so that it worked (this must have been wrong for years and no-one used it until yesterday!)
→ Release 9.33.2
Sunday 14 July 2019
- There's a rare buglet that causes the "do I pass through here" code to break in a way I have been unable to reproduce. I've changed the way the data is written which should avoid this.
- Fixed error in the edit_detail template that caused "selectedDays" to appear in the drop down if days was already selected (mentioned as an aside in issue 625).
- Added the ability to override the default flow for waterways by setting a value in a new field in waterwayends. Delivers on issue 610 in a not-too-hacky way.
→ Release 9.33.3
- Tweak to prevent errors on some routes with minimal waterway types (looks like longstanding bug tickled by new code)
→ Release 9.33.3.1
To Saturday 20 July 2019
- Work to make small but important improvements to output from issue 621:
- "Today's journey involves 1 moveable bridge of which 1 is usually left open;" replaced by "Today's journey involves 1 moveable bridge which is usually left open;"
- You will pass through Leek Tunnel and through Leek Tunnel." replaced by "You will pass through Leek Tunnel twice."
- Moved lots of code that was shared between "totals.cst" and "passed_through.cst" into macros in "output_macros.cst"
- Fixed what looked to be a bit of debugging that was causing the additional info about a place to appear twice - once following the name and again small underneath.
- Started work to capture more information about the assorted ways the "attributes" field is used, to support all the changes needed for issue 598.
→ Release 9.33.4
Sunday 21 July 2019
- Fixed a few errors in the geodata control program that should reduce the amount of refetching of data
Saturday 27 July 2019
- More improvements to the geodata control, including handling empty fields
- Prerelease patch for mooring_JSON editing in history text
- New "logit" command to allow easy logging of complicated things (like geodata) which can be turned on and off easily
A first - my pre-publish checking framework found a bug in the geodata code that would have caused all sorts of problems had it gone live. Success!
→ Release 9.33.5
Sunday 28 July 2019
- When you change the attributes of a place it can affect the CRT asset matching. Added code to allow for geodata to be affected by changes other than just coordinates, in an efficient way to avoid refetching other fields.
Monday 29 July 2019
- Fixed a bug in the crt_asset code for aqueducts.
→ Release 9.33.6
Tuesday 20 August 2019
- Tweak to regenerate maps when lock direction is reversed, fixes issue 636.
Wednesday 21 August 2019
- A bug fix to address issue 635 - failure to show daily maps in itineraries
- A new collection of icons for facilities (water points etc). Currently only shown on gazetteer strip maps, but will expand into other places. Water, rubbish, chemical toilets, recycling and mooring are featured at present. These will become visible over time as the data refreshes.
→ Release 9.33.7
Thursday 22 August 2019
- Removed all url-rewriting code from templates, simplifying them significantly (any server capable of supporting canalplan will support URL rewriting).
- Made facility code general purpose not built into local tables
- Added facility symbols to routes (list formats)
- Added pump-out
- Fixed a coding error for reading config files that this work triggered
→ Release 9.33.8
Saturday 24 August 2019
- Extended symbols into all output modes including PDFs
To Saturday 7 September 2019
- Added separate coordinates for place symbols so they don't have to be in the middle of the canal
- Added separate coordinates for facilities (water, rubbish, chemical toilets, pumpouts so far)
- New map editing mode for these
- Appear on maps
→ Release 9.34 *ADDS* Separate symbols for places and facilities
- Stopped a faulty pop-up and JS error when you mousedover a symbol in the new edit screen [pre-release]
- Changed sprite building to put new sprites in the correct directory on the server
- Fixed (pre-release) a bug that stopped PDF generation with symbols
- Ran script to put sanitary stations and moorings on maps
- Turned up resolution of maps, which makes generation of tiles a bit slower, but it doesn't happen too often and means the new stuff doesn't wander between edits.
- Added toilets to the facilities
- Clicking on stand-alone symbols doesn't open a new window with an error in it
Sunday 8 September 2019
- Put code in to deal with a flurry of bad requests from grotty bots
- Reorganised map edit code - can now turn everything on and off and the data follows
- Added ability to hide background icons when editing
- Added template for symbol editing in place history
→ Release 9.34.1